[PATCH 0/6] Rebase of Pieter's "set test prereqs"

Thomas Jost schnouki at schnouki.net
Wed Nov 16 06:33:49 PST 2011


Hello list,

This is another rebased version of Pieter's series to add GPG and Emacs as test
prereqs, plus some additions on my own. (Rebased and posted as requested by
Pieter [1].)

Changes as compared to Pieter's patches (including parts from [2]):
- prereqs are not tested using test_expect_success as they were in Pieter's
  original patches, but using a new function called test_set_bin_prereq. I wrote
  this before the gdb prereq was added, hence the different way to set it.

- some fixes in Pieter's patches so that it actually works when gpg is not
  installed. Can't exactly remember what (...but you can just check his original
  patches), but in the end it was working fine in a chroot without gpg.

- since Emacs is now run using dtach, the emacs prereq also depends on dtach.
  The presence of emacs and dtach is also checked in the test_emacs() function
  of the test suite.

- testing for prereqs is now done using the "hash" built-in instead of "which",
  as suggested in [3].

Tested with and without dtach. A previous version of this series was also
without emacs/gpg in a chroot, but not this one :)

[1] id:"874ny4fcdz.fsf at praet.org"
[2] id:"1317660447-27520-1-git-send-email-schnouki at schnouki.net"
[3] id:"87zkgemodd.fsf at praet.org"

Pieter Praet (4):
  test: add 'GnuPG' prereq to dependent 'crypto' tests
  test: add 'Emacs' prereq to dependent 'crypto' tests
  test: add 'Emacs' prereq to dependent 'emacs' tests
  test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer'
    tests

Thomas Jost (2):
  test: define a helper function for defining prereqs on executables
  test: check if emacs and dtach are available in test_emacs()

 test/crypto                    |   46 +++++++++++++++-------
 test/emacs                     |   82 +++++++++++++++++++++------------------
 test/emacs-large-search-buffer |    9 +++-
 test/test-lib.sh               |   17 ++++++++
 4 files changed, 99 insertions(+), 55 deletions(-)

-- 
1.7.7.3



More information about the notmuch mailing list