[PATCH 0/6] Rebase of Pieter's "set test prereqs"
Jameson Graef Rollins
jrollins at finestructure.net
Wed Nov 16 10:53:42 PST 2011
On Wed, 16 Nov 2011 15:33:49 +0100, Thomas Jost <schnouki at schnouki.net> wrote:
> Hello list,
>
> This is another rebased version of Pieter's series to add GPG and Emacs as test
> prereqs, plus some additions on my own. (Rebased and posted as requested by
> Pieter [1].)
>
> Changes as compared to Pieter's patches (including parts from [2]):
> - prereqs are not tested using test_expect_success as they were in Pieter's
> original patches, but using a new function called test_set_bin_prereq. I wrote
> this before the gdb prereq was added, hence the different way to set it.
Hey, Thomas. Thanks so much for this work. This sounds like a better
solution.
However, in the patches you send I see a lot of changes of the form
-test_expect_success 'emacs delivery of encrypted message with attachment' \
+test_expect_success GPG 'emacs delivery of encrypted message with attachment' \
and
-test_expect_equal \
+test_expect_equal GPG \
which seems to contradict what you've said above. Not to mention that I
don't see anything that modifies calls to the test_expect_ functions.
Basically I see a lot more in the diffs than I would have expected in a
cursory look. Is this just a rebase flub, or is there something I'm
missing?
jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111116/11f48b4d/attachment.pgp>
More information about the notmuch
mailing list