revision 3: easing access to the cryptographic envelope

David Bremner david at
Sun May 26 09:54:29 PDT 2019

Daniel Kahn Gillmor <dkg at> writes:

> On Sun 2019-05-26 09:01:46 -0300, David Bremner wrote:
>> Daniel Kahn Gillmor <dkg at> writes:
>>> This is the third revision of the series originally posted at
>>> id:20190424183113.29242-1-dkg at (revision 2 was at
>>> id:20190520032228.27420-1-dkg at
>>> This series addresses comments raised by David Bremner in his review.
>>> Thanks, Bremner!
>> I pushed this version, with 4 minor whitespace fixups (inserted spaces
>> and/or deleted blank lines) that I missed in my previous review.
> Thanks for these fixes, Bremner.  If you have a specific set of tooling
> that you use that i can adopt to catch those kinds of coding convention
> mishaps before submitting, i'd be happy to adopt it so things are
> "clean".  Bonus points if it integrates into emacs via .dir-locals.el or
> something :P

To be honest my main mechanism for catching those problems is Tomi
;). There is also a reasonable uncrustify configuration that I don't use
as often as I should, mainly because the baseline in various files is
not there. Perhaps if we did more some global whitespace cleanup this
would be more helpful. To try it out run

% uncrustify -c devel/uncrustify.cfg --replace $files


% git diff

to see what changed.

% find -name .git -prune -o -type f -a -regex '.*[.]\(c\|h\|cc\)' -print -exec uncrustify -c devel/uncrustify.cfg --replace {} \;

yields a whopping 1933 insertions and 1903 deletions. Perhaps there are
some places where the uncrustify config needs tuning, but none of the
output looked crazy to me. Two things I noticed causing lots of changes

1) "!foo" -> "! foo"
2) putting a leading * in front of multi-line comments

If we do decide to rip off the bandage, that will cause a certain amount
of rebasing pain for any patch series in flight; now (i.e after the
release) is actually a pretty good time from my point of view, but
others (e.g. you) might feel differently.

More information about the notmuch mailing list