[PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it

[Tomi Ollila]

On Sun, Apr 06 2014, David Bremner <david at tethera.net> wrote:

> Tomi Ollila <tomi.ollila at iki.fi> writes:
>
>> +;; You should have received a copy of the GNU General Public License
>> +;; along with Notmuch.  If not, see <http://www.gnu.org/licenses/>.
>
> Do you think we need a copyright header in a generated file?

This is more due to the template-to-file conversion simplicity than need
and I thought there is no harm having the copyright there. At least the
file is consistent with others in that sense.

>> +
>> +(defconst notmuch-emacs-version %VERSION%
>> +  "Version string of this version of Notmuch Emacs MUA.")
>> +
>
> At the risk of being very picky, how about less copies of Version, maybe
> "Version of Notmuch Emacs MUA"

Actually that is a good point:

What I put there was modeled after `emacs-version':
"Version numbers of this version of Emacs."

Then, gnus has (lisp/gnus/gnus.el in emacs sources):

(defconst gnus-version-number "5.13"
  "Version number for this version of Gnus.")

(defconst gnus-version (format "Gnus v%s" gnus-version-number)
  "Version string for this version of Gnus.")

All of these are of type string, and the documentation states whether 
it is (at least close to) numeric or not within string. But there is
no tradition of what *-version should contain.

Therefore if we say "Version of Notmuch Emacs MUA", it can contain
"0.17+163~gcedea23" "0.18" or "unknown"


> Other than that, the series looks OK, and works on Debian now.
>
> d

Tomi