[PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it

David Bremner david at tethera.net
Sun Apr 6 11:42:06 PDT 2014


Tomi Ollila <tomi.ollila at iki.fi> writes:

> +;; You should have received a copy of the GNU General Public License
> +;; along with Notmuch.  If not, see <http://www.gnu.org/licenses/>.

Do you think we need a copyright header in a generated file?

> +
> +(defconst notmuch-emacs-version %VERSION%
> +  "Version string of this version of Notmuch Emacs MUA.")
> +

At the risk of being very picky, how about less copies of Version, maybe
"Version of Notmuch Emacs MUA"

Other than that, the series looks OK, and works on Debian now.

d



More information about the notmuch mailing list