[PATCH 0/5] Document notmuch-pick and some bugfixes
Mark Walters
markwalters1009 at gmail.com
Mon Jul 1 00:53:58 PDT 2013
This adds some documentation to all the defvars in notmuch-pick and to
the notmuch-pick function itself (as suggested by David in
id:87li5rtvbh.fsf at zancas.localnet. This series replaces
id:1372627117-31188-1-git-send-email-markwalters1009 at gmail.com but
does still need to be applied on top of the main series there (because
it documents the pick function as it is after that change).
When documenting the defvars I found some trivial bugs: the most
serious being the wrong variable name being made buffer-local. This is
less serious than it could be as this variable was just used to try
and avoid closing the message pane if the user had loaded a different
buffer into it.
The other "bugs" were defvars for variables which are no longer
used. In one case a moderate amount of effort was made passing this
unused variable around so the patch to remove it is not tiny and thus
its removal is delayed until a followup series.
Finally, when looking at which functions did not have docstrings (some
still need to be added after this series) I found an unused historical
function so remove that too.
Best wishes
Mark
Mark Walters (5):
contrib: pick: add a docstring for the main notmuch-pick function
contrib: pick: add docstrings to all defvars
contrib: pick: bugfix: make the right variable buffer-local
contrib: pick: remove unused variable
contrib: pick: remove unused function
contrib/notmuch-pick/notmuch-pick.el | 71 ++++++++++++++++++++-------------
1 files changed, 43 insertions(+), 28 deletions(-)
--
1.7.9.1
More information about the notmuch
mailing list