[PATCH] contrib: pick: bugfix for pick splitting the window excessively

[Jameson Graef Rollins]

On Sun, Dec 09 2012, Mark Walters <markwalters1009 at gmail.com> wrote:
> Previously if you carried on past the last message in a pick view pick
> would get confused and `forget' about the split pane and would try and
> re-split when moving up again. This was due to faulty logic in
> notmuch-pick-show-message: something that should have been in the (when message)
> clause was not.
>
> Thanks to jrollins for the bug report.
> ---
>
> A simple bugfix: I can reproduce the bug that jrollins found and this
> fixes it for both of us.
>
> Best wishes
>
> Mark
>
>  contrib/notmuch-pick/notmuch-pick.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 63776d5..a46ef6e 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -402,8 +402,8 @@ Does NOT change the database."
>        (with-selected-window notmuch-pick-message-window
>  	(setq current-prefix-arg '(4))
>  	(setq buffer (notmuch-show id nil nil nil)))
> -      (notmuch-pick-tag-update-display (list "-unread")))
> -    (setq notmuch-pick-message-buffer buffer)))
> +      (notmuch-pick-tag-update-display (list "-unread"))
> +      (setq notmuch-pick-message-buffer buffer))))
>  
>  (defun notmuch-pick-show-message-out ()
>    "Show the current message (in whole window)."

Sorry, I should have responded to this immediately.  This is a bug fix,
and I've tested it and it works perfectly.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121210/315887f1/attachment-0001.pgp>