[PATCH] contrib: pick: bugfix for pick splitting the window excessively

Mark Walters markwalters1009 at gmail.com
Sun Dec 9 12:17:29 PST 2012


Previously if you carried on past the last message in a pick view pick
would get confused and `forget' about the split pane and would try and
re-split when moving up again. This was due to faulty logic in
notmuch-pick-show-message: something that should have been in the (when message)
clause was not.

Thanks to jrollins for the bug report.
---

A simple bugfix: I can reproduce the bug that jrollins found and this
fixes it for both of us.

Best wishes

Mark

 contrib/notmuch-pick/notmuch-pick.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 63776d5..a46ef6e 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -402,8 +402,8 @@ Does NOT change the database."
       (with-selected-window notmuch-pick-message-window
 	(setq current-prefix-arg '(4))
 	(setq buffer (notmuch-show id nil nil nil)))
-      (notmuch-pick-tag-update-display (list "-unread")))
-    (setq notmuch-pick-message-buffer buffer)))
+      (notmuch-pick-tag-update-display (list "-unread"))
+      (setq notmuch-pick-message-buffer buffer))))
 
 (defun notmuch-pick-show-message-out ()
   "Show the current message (in whole window)."
-- 
1.7.9.1



More information about the notmuch mailing list