[PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)

Austin Clements amdragon at MIT.EDU
Thu Apr 5 19:24:36 PDT 2012


On Sat, 31 Mar 2012, Mark Walters <markwalters1009 at gmail.com> wrote:
> This is version 2 of the exclude= series (version 1 is [1]).
>
> The main changes are the addition of some systematic notmuch-search
> tests for all the exclude options, and I no longer add the
> exclude=flag option to notmuch-show.c (the output was too similar to
> exclude=false to be worth keeping).
>
> Best wishes
>
> Mark
>
>
> id:"1331836925-31437-1-git-send-email-markwalters1009 at gmail.com".

Sorry for the slow review.  Besides my fairly superficial comments,
everything else LGTM.

It's great to see exclude really turning into a robust feature!  I had
no idea the path would be this long when I wrote that original little
hack.  I'm thankful you're sticking with it.


More information about the notmuch mailing list