[PATCH v3 2/2] search: Support automatic tag exclusions

[Xavier Maillard]

Hey Pieter,

On Thu, 19 Jan 2012 20:19:00 +0100, Pieter Praet <pieter at praet.org> wrote:
> Nice feature!  I won't be using it myself, but I can imagine it being
> *very* useful for those who still feel the need to "delete" email :).

Adding a 'deleted' tag does not mean there will be a delete/purge
process ;) (currently I got 5k messages with the tag deleted ;). 

> Nitpicking:
> 

[ ... ]

>   So I'd like to suggest replacing all occurences of "auto_exclude_tags"
>   with "search_exclude_tags" (and simply "exclude_tags" in the args to
>   `_config_get_list' and `_config_set_list', of course).

+1
 
>   Unfortunately, this would also partially invalidate your recent NEWS
>   submission [2].
> 
> - If the 'search.exclude_tags' option is missing from the config file,
>   its value is automatically set to "deleted;spam;", which probably isn't
>   a sane default.  Luckily, you've already provided the solution [3].

I am against doing something /unsafe/ in the user's back. If there is no
option set intentionnaly by the user, there is nothing notmuch should
do -i.e no exclusion -

> - To make new users aware of the config option's existence, we should
>   prompt them to configure it during setup.

+1

/Xavier