[PATCH] patchformatting: Test Suite Enhancements
Thomas Schwinge
thomas at schwinge.name
Thu Sep 29 11:24:05 PDT 2011
Based on the emails starting at
id:"87liu2kcq6.fsf at servo.factory.finestructure.net".
---
Hi!
I applied the attached patch, based on this thread's discussion.
Grüße,
Thomas
---
patchformatting.mdwn | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/patchformatting.mdwn b/patchformatting.mdwn
index cf5bf81..914371d 100644
--- a/patchformatting.mdwn
+++ b/patchformatting.mdwn
@@ -41,6 +41,16 @@ Eric S. Raymond has written good
[Software Release Practice HOWTO](http://tldp.org/HOWTO/Software-Release-Practice-HOWTO/).
Check what he has to say about this issue.
+### Test Suite Enhancements
+
+New features as well as bug fixes should typically come with test suite
+enhancements. The test suite changes should be done first (tagged as *expected
+to fail*), and the feature implementation or bug fix should come second
+(removing the *expected to fail* tag). This way, the test suite specifies the
+behavior you're trying to implement, be it a new feature or a bug fix. By
+defining beforehand exactly what you expect to happen, everyone can confirm
+that your patch achieves what it is meant it to.
+
## Prepare patches for e-mail submission
If you've made just one commit (containing just one bugfix or new feature)
--
1.7.6.3
More information about the notmuch
mailing list