[PATCH] notmuch restore --accumulate
Jameson Graef Rollins
jrollins at finestructure.net
Fri Sep 9 11:58:14 PDT 2011
On Fri, 09 Sep 2011 19:22:49 +0200, Thomas Schwinge <thomas at schwinge.name> wrote:
> Ah, that's indeed a good approach for bug fixes (and it also preserves
> git bisect compatibility), but still: why separate patches for new
> functionality? (I'm not trying to be a pain here, but would like to
> understand your rationale behind this.)
I tend to think of the test as an actual spec of the behavior I'm trying
to implement. By defining before hand exactly what I expect to happen I
can confirm that my patch achieves what I want it to.
As an example, you might look at my patch that adds better rfc822 part
handling [0]. I tried to fully flesh out what I wanted to happen in the
test first, and then modified the code to achieve that result.
jamie.
[0] id:"1307320169-29905-4-git-send-email-jrollins at finestructure.net"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110909/7af439b5/attachment.pgp>
More information about the notmuch
mailing list