[PATCH] new: Improved workaround for mistaken new directories

[Carl Worth]

On Wed, 29 Jun 2011 19:00:01 -0400, Austin Clements <amdragon at MIT.EDU> wrote:
> We work around this by setting the new directory's database mtime to
> -1 before scanning anything in the new directory.  This also obviates
> the need for the workaround used in 8c39e8d6.

Thanks. This is pushed.

> +    /* XXX This is a temporary workaround.  If we don't update the
> +     * database mtime until after processing messages in this
...
> +     * A better solution would be for notmuch_database_get_directory
> +     * to indicate if it really created a new directory or not, either
> +     * by a new out-argument, or by recording this information and
> +     * providing an accessor.

A much better "XXX" comment! It tells the potential reader of the future
what to do to be able to remove the comment. Thanks so much.

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110629/76c34e16/attachment.pgp>