[PATCH] Wrap the compat header in extern "C" { } when compiling C++ sources
Carl Worth
cworth at cworth.org
Tue Apr 27 10:43:11 PDT 2010
On Tue, 27 Apr 2010 19:27:17 +0200, Tomas Carnecky <tom at dbservice.com> wrote:
> This fixes a build error on OpenSolaris where the final liking of
> notmuch fails because the linker can't find strcasestr() referenced
> from thread.cc.
Thanks for the fix. I've pushed this out, (and just in time for 0.3.1).
> Is it safe to use NOTMUCH_BEGIN/END_DECLS in the compat header? The sha1 header
> also uses ifdef __cplusplus instead of that define..
The compat code doesn't include notmuch.h so doesn't see the definition
of those macros. So what you did here is fine.
For the sha1 code---we basically have kept that unchanged from upstream,
so it also does its own thing here.
-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100427/da8cf538/attachment.pgp>
More information about the notmuch
mailing list