sort order regression

Jesse Rosenthal jrosenthal at jhu.edu
Thu Apr 22 07:21:11 PDT 2010


On Thu, 22 Apr 2010 10:14:16 -0400, Jesse Rosenthal <jrosenthal at jhu.edu> wrote:
> Just to follow up on this, it seems that the regression comes from the
> fix Carl introduced in 2a1a4f0551 to make his simplification of my patch
> (simplification = 36e4459a3 , my patch = 4971b85641) pass tests. The
> question is whether my original, more complicated version would have
> passed the tests without the regressing fix.

Okay, I just tested using the current test suite: my patch (4971b85641)
passes all tests, while Carl's simplification fails.

My suggestion would be to revert both the simplification and the fix to
enable the simplification to pass: (36e4459a3, 2a1a4f0551).

Should we send reverts as patches?

Best,
Jesse


More information about the notmuch mailing list