[notmuch] _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message

Keith Packard keithp at keithp.com
Fri Nov 27 10:10:58 PST 2009

On Fri, 27 Nov 2009 04:46:54 -0800, Carl Worth <cworth at cworth.org> wrote:

> Did the "if" statement immediately afterwards just look like error
> checking? It's not:

Yes, it did (I think my brain may have auto-inserted a '!' there).

Ok, having read the code a bit more carefully, this does look correct.

I have to say that _notmuch_message_create is a bit of a tricky name; as
it doesn't create a message so much as load a message from the database.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091127/01d51465/attachment.pgp>

More information about the notmuch mailing list