[notmuch] _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message

Carl Worth cworth at cworth.org
Fri Nov 27 04:46:54 PST 2009

On Mon, 23 Nov 2009 12:29:44 -0800, Keith Packard <keithp at keithp.com> wrote:
> Looking at _notmuch_message_create_for_message_id, the first thing it
> does is call notmuch_database_find_message, but the returned 'message'
> is never used. I haven't tried, but I suspect this call could just be
> removed.

Did the "if" statement immediately afterwards just look like error
checking? It's not:

    message = notmuch_database_find_message (notmuch, message_id);
    if (message)
	return talloc_steal (notmuch, message);

That's "if there's a message is in the database with this message-id,
return it straight away".

Or am I looking at the wrong bit of code?


More information about the notmuch mailing list