[PATCH 1/2] legacy-display: accept text/plain legacy display parts

[Daniel Kahn Gillmor]

On Tue 2019-12-24 10:59:09 +0000, David Edmondson wrote:
> Patch looks good, though I would quite like there to be a comment in the
> code. Something simple like:
>
> /* text/rfc822-headers was replaced by text/plain as the MIME type for
> “Legacy Display” parts - we allow either. */

I have no objection to having this comment in the code (though i think
i'd replace U+201C LEFT DOUBLE QUOTATION MARK and U+201D RIGHT DOUBLE
QUOTATION MARK with U+0022 QUOTATION MARK.  i don't think we have any
non-ASCII text in our C source at the moment, and this doesn't seem like
the right place to introduce it.


Since the code will be read in the future, not the past, i think the
right comment might be:

 /* Early implementations that generated "Legacy Display" parts used
    Content-Type: text/rfc822-headers, but text/plain is more widely
    rendered, so it is now the standard choice.  We accept either as a
    Legacy Display part. */

Bremner, if you are considering a merge, and want to inject this comment
yourself, that's fine with me.  let me know if you want me to send
another revision instead.

        --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20191224/88d6ba8e/attachment.sig>