[PATCH] test: add a known broken test for S/MIME decryption

Daniel Kahn Gillmor dkg at fifthhorseman.net
Mon Dec 9 12:27:37 PST 2019


On Sun 2019-11-17 21:58:12 -0400, David Bremner wrote:
> This should serve to clarify this feature is not implimented in
> notmuch yet.
> ---
>  test/T355-smime.sh | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/test/T355-smime.sh b/test/T355-smime.sh
> index 336da917..11a4d6cd 100755
> --- a/test/T355-smime.sh
> +++ b/test/T355-smime.sh
> @@ -94,4 +94,13 @@ Verification successful
>  EOF
>  test_expect_equal_file EXPECTED OUTPUT
>  
> +test_begin_subtest "Decryption (notmuch CLI)"
> +test_subtest_known_broken
> +notmuch show --decrypt=true subject:"test encrypted message 001" |\
> +    grep "^This is a" > OUTPUT
> +cat <<EOF > EXPECTED
> +This is a test encrypted message.
> +EOF
> +test_expect_equal_file EXPECTED OUTPUT
> +
>  test_done

This looks good to me.  I suspect that when we get full PKCS#7
decryption support, we'll want to use keys and certificates slightly
more sophisticated than the ones in this change (e.g. using the keys and
certs from https://www.ietf.org/id/draft-dkg-lamps-samples-01.html), but
the proposed patch here is a good placeholder that documents the current
state of play. And we can always update the test later as the new
functionality comes in.

Please merge!

       --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20191209/41edd613/attachment.sig>


More information about the notmuch mailing list