python CFFI bindings integration into notmuch build/test

Floris Bruynooghe flub at devork.be
Thu Nov 14 10:52:52 PST 2019


Hi,

Thanks for carrying on with this!

I'm a little confused with how to follow this, is the current state of
the code somewhere in a repo/branch where I can try things out and make
changes from?

On Tue 05 Nov 2019 at 22:22 -0400, David Bremner wrote:

> Tomi Ollila <tomi.ollila at iki.fi> writes:
>
>
>> alternative:
>>
>>        ...
>>        print('Invoking: {}'.format(' '.join(cmd)))
>>         
>>        def preexec_fn(): os.environ['NOTMUCH_CONFIG'] = str(cfg_fname) 
>>
>>        proc = subprocess.run(cmd, timeout=5, preexec_fn=preexec_fn)
>>        ...
>>
>> The unix fork ... (here preexec_fn called in child) ... exec model is
>> superior to any other alternative ! =D
>
> I don't consider myself a good judge of python style, so I'll defer to
> Floris on that one.

I'd have gone with what David wrote to be fair, mostly because it's
pretty simple to see what's going on where for the preexec_fn I'd have
to look at the docs.  Not sure if this has much to do with Python style
though, more with how much you like Unix tricks.


Cheers,
Floris


More information about the notmuch mailing list