[PATCH 2/2] test: replace use of gdb with LD_PRELOAD shims in T070-insert.sh

Daniel Kahn Gillmor dkg at fifthhorseman.net
Sun Jun 9 17:52:24 PDT 2019


One more nit-pick:

On Sun 2019-05-26 10:08:54 -0300, David Bremner wrote:
> +    test_expect_code 0 "notmuch_with_shim shim-$code insert --keep < \"$gen_msg_filename\""

This kind of business breaks obscurely if $gen_msg_filename happens to
have U+0022 QUOTATION MARK in it.  That's a pretty perverse situation,
but i'd generally prefer to use bash's builtin printf's %q for
robustness.

A revised patch will follow shortly that fixes both of my nitpicks.

  --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20190610/94c8d496/attachment-0001.sig>


More information about the notmuch mailing list