[PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

Daniel Kahn Gillmor dkg at fifthhorseman.net
Sat May 25 07:23:50 PDT 2019


On Fri 2019-05-24 22:38:12 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:
>
>> On Thu 2019-05-23 22:13:59 -0300, David Bremner wrote:
>>> Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:
>>>
>>>> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
>>>> index 353f721e..68171153 100644
>>>> --- a/emacs/notmuch-crypto.el
>>>> +++ b/emacs/notmuch-crypto.el
>>>> @@ -93,6 +93,7 @@ mode."
>>>>  (defun notmuch-crypto-insert-sigstatus-button (sigstatus from)
>>>>    (let* ((status (plist-get sigstatus :status))
>>>>  	 (help-msg nil)
>>>> +	 (show-button t)
>>>>  	 (label "Signature not processed")
>>>
>>> This should probably be nil, since that particular value is never used,
>>> iiuc. I can amend it if you agree.
>>
> [snip]
>>
>> If i've misunderstood the e-lisp (entirely possible!) i would be happy
>> to be corrected.
>
> No, you've just misunderstood my reply. I refer to the existing initialization
> of "label", which now seems obsolete to me.

Ah, sorry!  i understand now, and yes, i agree that label shold be
initialized to nil.  If you're willing to amend it that sounds good to
me.

Thanks for catching this.

        --dkg


More information about the notmuch mailing list