[PATCH] lib/message-file: close stream in destructor

David Bremner david at tethera.net
Thu May 9 18:42:13 PDT 2019

Will Dietz <w at wdtz.org> writes:

> Great, thank you!
> Much appreciated, I actually was running into this yesterday.
> ( which for whatever reason led to posting this on the subject:
> https://github.com/afewmail/afew/issues/193#issuecomment-490766850 )
> Would the valgrind support in the test suite catch this sort of thing
> (fd leak on relatively common path)?

Good question. It didn't in a naive test I tried (just running notmuch
new under valgrind --track-fds). This is probably has to do with glib
cleaning up the relevant objects during shutdown.

More information about the notmuch mailing list