[PATCH v2 1/3] emacs: test notmuch-show during message decryption

[Daniel Kahn Gillmor]

On Fri 2019-05-03 17:59:49 +0000, David Bremner wrote:
> Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:
>
>> We did not have a test showing what message decryption looks like
>> within notmuch-emacs.  This change gives us a baseline for future work
>> on the notmuch-emacs interface.
>> ---
>>
>> The difference between this and the prior version of the patch is that
>> it updates T357-index-decryption.sh as well, to ensure all tests pass.
>>
>
> I don't _think_ this is gmime3 related, but I get
>
> T357-index-decryption: Testing indexing decrypted mail
>  FAIL   indexing message fails when secret key not available
> 	--- T357-index-decryption.31.expected	2019-05-03 17:57:26.701988487 +0000
> 	+++ T357-index-decryption.31.output	2019-05-03 17:57:26.701988487 +0000
> 	@@ -1,4 +1,4 @@
> 	 #notmuch-dump batch-tag:3 config,properties,tags
> 	++encrypted +inbox +unread -- id:basic-encrypted at crypto.notmuchmail.org
> 	 +encrypted +inbox +unread -- id:simple-encrypted at crypto.notmuchmail.org
> 	 #= simple-encrypted at crypto.notmuchmail.org index.decryption=failure
> 	-+encrypted +inbox +unread -- id:basic-encrypted at crypto.notmuchmail.org
>  FAIL   cleartext index recovery on reindexing with stashed session keys
> 	--- T357-index-decryption.33.expected	2019-05-03 17:57:26.817988197 +0000
> 	+++ T357-index-decryption.33.output	2019-05-03 17:57:26.817988197 +0000
> 	@@ -1 +1 @@
> 	-thread:0000000000000001   2016-12-22 [1/1] Daniel Kahn Gillmor; encrypted message (encrypted inbox unread)
> 	+thread:0000000000000002   2016-12-22 [1/1] Daniel Kahn Gillmor; encrypted message (encrypted inbox unread)
>
> Applying on top of 103c11822


hm, right, thanks.  The issue here is likely that your filesystem's
readdir puts the messages in the corpus in a different order than mine
does.    So these failures are due only to the order in which "notmuch
new" encounters the messages in corpus/crypto.

I'll send a revised patch that should be ordering-independent.  thanks
for catching this!

    --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20190506/156925e6/attachment-0001.sig>