[PATCH 1/3] tests: remove some redundant pre-cleanup of the corpus MAIL_DIR

Tomi Ollila tomi.ollila at iki.fi
Sun May 5 03:22:06 PDT 2019


On Sat, May 04 2019, Jameson Rollins wrote:

This change LGTM, marked trivial, removed needs-review

> From: Jameson Graef Rollins <jrollins at finestructure.net>
>
> add_email_corpus itself does an rm -rf $MAIL_DIR, so these are not necessary.
> ---
>  test/T100-search-by-folder.sh | 1 -
>  test/T650-regexp-query.sh     | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/test/T100-search-by-folder.sh b/test/T100-search-by-folder.sh
> index a090f3d2..409cfdcc 100755
> --- a/test/T100-search-by-folder.sh
> +++ b/test/T100-search-by-folder.sh
> @@ -56,7 +56,6 @@ output=$(notmuch search folder:duplicate/bad/olds | notmuch_search_sanitize)
>  test_expect_equal "$output" "thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Bears (inbox unread)"
>  
>  # folder: and path: searches with full corpus
> -rm -rf $MAIL_DIR
>  add_email_corpus
>  
>  # add some more dupes
> diff --git a/test/T650-regexp-query.sh b/test/T650-regexp-query.sh
> index 92334ba0..43af3b47 100755
> --- a/test/T650-regexp-query.sh
> +++ b/test/T650-regexp-query.sh
> @@ -47,7 +47,6 @@ output=$(notmuch search 'path:/^bad$/' | notmuch_search_sanitize)
>  test_expect_equal "$output" "thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; To the bone (inbox unread)"
>  
>  # Use "standard" corpus from here on.
> -rm -rf $MAIL_DIR
>  add_email_corpus
>  
>  notmuch search --output=messages from:cworth > cworth.msg-ids
> -- 
> 2.20.1
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch


More information about the notmuch mailing list