[PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable

Tomi Ollila tomi.ollila at iki.fi
Wed Apr 3 13:10:56 PDT 2019


On Tue, Apr 02 2019, Örjan Ekeberg wrote:

> Tomi Ollila <tomi.ollila at iki.fi> writes:
>> two things
>>
>> - I wonder whether we could drop (defun notmuch-message-mark-replied ()...)
>>   - why is it needed for backward compatibility ?
>
> Yes, it would be cleaner to simply remove it.  My thought was that there
> is a slight risk that someone is explicitly using or manipulating this
> function in some personal code.  This is probably very unlikely, so I am
> more than happy to drop it.

I think dropping is safe.

>> - A test of a few would be nice to see how this behaves -- and we can see
>>   that this still works e.g. on emacs 24...
>
> Indeed.  I did consider this, but since I am not at all familiar with
> how to write such tests, I did not proceed with this.

No-one is, but with little investigation, and then (ab)using some of the
current emacs tests as base for a new test should be doable.

>
> /Örjan

Tomi


More information about the notmuch mailing list