[PATCH v1 2/2] emacs: Update integration with third party packages.
Tomi Ollila
tomi.ollila at iki.fi
Thu Oct 4 14:16:58 PDT 2018
On Thu, Oct 04 2018, David Edmondson wrote:
> `mm-inline-text-html-with-images' was removed from mm-decode.el in
> 2016 and replaced with `mm-html-inhibit-images'.
>
> `gnus-select-frame-set-input-focus' was removed from gnus-util.el in
> 2016 and existed only for XEmacs compatibility.
2/2 looks good to me
1/2 is IMO okayish (but ymmv); i personally don't like
__attribute__((unused)) as it is effectively the same as (void)var (neither
notices the case when variable is actually used) also, 1/2 is farther
away to fit onto 80 column terminal window ;/
Tomi
> ---
> emacs/notmuch-mua.el | 2 +-
> emacs/notmuch-show.el | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index df2ac447..e205fa4c 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -306,7 +306,7 @@ modified. This function is notmuch addaptation of
> (if window
> ;; Raise the frame already displaying the message buffer.
> (progn
> - (gnus-select-frame-set-input-focus (window-frame window))
> + (select-frame-set-input-focus (window-frame window))
> (select-window window))
> (funcall switch-function buffer)
> (set-buffer buffer))
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index a0a58373..78f1af47 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -604,7 +604,7 @@ will return nil if the CID is unknown or cannot be retrieved."
> (unless (assq 'notmuch-show-mode w3m-cid-retrieve-function-alist)
> (push (cons 'notmuch-show-mode #'notmuch-show--cid-w3m-retrieve)
> w3m-cid-retrieve-function-alist)))
> - (setq mm-inline-text-html-with-images t))
> + (setq mm-html-inhibit-images nil))
>
> (defvar w3m-current-buffer) ;; From `w3m.el'.
> (defun notmuch-show--cid-w3m-retrieve (url &rest args)
> --
> 2.19.0
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
More information about the notmuch
mailing list