Handling mislabeled emails encoded with Windows-1252
David Bremner
david at tethera.net
Tue Jul 31 02:07:03 PDT 2018
Sebastian Poeplau <sebastian.poeplau at eurecom.fr> writes:
>> Nice, I'll add it.
>
> Updated patch attached.
>
> Cheers,
> Sebastian
Thanks to both of you for working on this. The code looks ok to me, I
have only some procedural comments.
In order to merge it I'll need at least one test. I think
test/T300-encoding.sh is probably the right place. There are a few
different styles of test; you can either put things in variables as in
that file, or use the more dominant
test_subtest_begin_test "description"
cat << EOF > EXPECTED
this is my expected output
EOF
notmuch show STUFF > OUTPUT
test_expect_equal_file EXPECTED OUTPUT
Feel free to bug the list for help on making tests (or #notmuch on
freenode).
Please also use git-send-email to send your patch(es), with commit
messages with an eye to
https://notmuchmail.org/contributing/#index5h2
To minimize the chance of problems, it's probably best to base your
commits on master, although the patch you sent applied fine here.
Thanks,
David
More information about the notmuch
mailing list