[PATCH] devel: make printmimestructure py3 compatible

Daniel Kahn Gillmor dkg at fifthhorseman.net
Tue Jun 12 14:25:01 PDT 2018

On Tue 2018-06-12 09:57:52 -0400, Daniel Kahn Gillmor wrote:
> On Tue 2018-06-12 12:47:58 +0200, Thomas Schneider wrote:
>> Tomi Ollila <tomi.ollila at iki.fi> writes:
>>> On Mon, Jun 11 2018, Daniel Kahn Gillmor wrote:
>>>> Make printmimestructure work in python3 as well as python2.
>>>> PEP 394 suggests that python scripts that work with both python2 and
>>>> python3 should have a #!/usr/bin/python command line, so do that too.
>>> I did not see PEP 394 suggesting to change 
>>> -#!/usr/bin/env python
>>> +#!/usr/bin/python
>>> just that 'python' should be able to run both python2 and python3 code.
>>> after the above change the code will not run on (those stupid) systems
>>> that install python to e.g. /usr/local/bin/.
>> For example all BSD systems, where the package manager installs to
>> /usr/local (and I do not think this is stupid).
>>> While I am not against this change, the commit message is misleading.
>> For the above reason, I am against changing the shebang at all.
> ok, but devel/nmbug/notmuch-report uses #!/usr/bin/python, and i was
> leaning toward making them consistent.  if we care about using the
> /usr/bin/env trick, we should use it consistently.
> i'm fine either way, my main goal with this series was to make
> printmimestructure compatible with both py2 and py3, and i have no
> interest in fighting about shebang lines.

the thread starting at id:20180612212110.32533-1-dkg at fifthhorseman.net
has a revised series that normalizes shebang lines on

    #!/usr/bin/env python

while still incorporating the fixes from myself and jamie.


More information about the notmuch mailing list