[PATCH 6/6] lib: choose oldest message when breaking reference loops
tomi.ollila at iki.fi
Wed Apr 25 04:48:42 PDT 2018
On Tue, Apr 24 2018, David Bremner wrote:
> Tomi Ollila <tomi.ollila at iki.fi> writes:
>> Otherwise the series _looks_ good do me. The thing that disturbs me are
>> these `strlen (in_reply_to)` contents. Perhaps SomeOne(TM) changes these
>> to e.g. in_reply_to in the future...
> That same file defines and uses an EMPTY_STRING macro. We should
> probably be consistent, either use that macro everywehre or
> nowhere. Perhaps move it to lib/notmuch-private.h?
I looked macro replacement for in_reply_to through internet, but
weren't smart enough to git grep notmuch source tree.
I'd say use it everwhere now that it is there (and move it...)
SMOP (or not so) for someone(tm)
More information about the notmuch