Bug?: manpages are only readable by root when doing sudo make install with umask 077

[Tomi Ollila]

On Wed, Jan 10 2018, Antoine Amarilli wrote:

> Hi Daniel,
>
> Thanks for your reply!
>
> On Wed, Jan 10, 2018 at 11:23:03AM -0500, Daniel Kahn Gillmor wrote:
>> On Wed 2018-01-10 16:38:14 +0100, Antoine Amarilli wrote:
>> how is the installation happening for you?  In Makefile.local, i see:
>> 
>> 	install -m0644 $(filter %.1.gz,$(MAN_GZIP_FILES)) $(DESTDIR)/$(mandir)/man1
>> 	install -m0644 $(filter %.5.gz,$(MAN_GZIP_FILES)) $(DESTDIR)/$(mandir)/man5
>> 	install -m0644 $(filter %.7.gz,$(MAN_GZIP_FILES)) $(DESTDIR)/$(mandir)/man7
>> 
>> which suggests that the -m would override the umask.
>
> That's right. Looking more closely I think the issue is only with the
> permissions of the directories /usr/local/share/man/man*, not the files
> that they contain. Of course this is still an obstacle for the manpages
> to be readable. So I guess the following in doc/Makefile.local (just
> above what you quoted):
>   
>         mkdir -p "$(DESTDIR)$(mandir)/man1"
>         mkdir -p "$(DESTDIR)$(mandir)/man5"
>         mkdir -p "$(DESTDIR)$(mandir)/man7"
>
> does not override the umask. I suspect that the parameter -m0644 should
> be passed to these invocations too.

If user has set umask to 077, should we override that (as we're now doing
with the files by giving explicit permissions) ?


>
> Best,
>
> -- 
> Antoine Amarilli
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch