[PATCH v3 04/15] crypto: move into libutil

[David Bremner]

Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:

> This prepares us for using the crypto object in both the library and
> the client.

I think we could be more precise about names here, to help outsiders get
up to speed on the code. libutil was renamed to libnotmuch_util, and
"the library" should probably be "libnotmuch".


> diff --git a/crypto.c b/util/crypto.c
> similarity index 97%
> rename from crypto.c
> rename to util/crypto.c
> index 4c1b7eec..39954ca0 100644
> --- a/crypto.c
> +++ b/util/crypto.c
> @@ -18,7 +18,11 @@
>   * Authors: Jameson Rollins <jrollins at finestructure.net>
>   */
>  
> -#include "notmuch-client.h"
> +#include "crypto.h"
> +#include "lib/notmuch-private.h"
> +

This seems like a kind of layering violation. What's in
notmuch-private.h that needs to be exported to things outside of lib/ ?