[PATCH v2 05/10] crypto: index encrypted parts when indexopts try_decrypt is set.
Daniel Kahn Gillmor
dkg at fifthhorseman.net
Mon Oct 9 21:27:44 PDT 2017
On Sat 2017-09-23 19:05:40 +0300, Jani Nikula wrote:
> I'd like this #if block to be abstracted to separate functions for gmime
> 2 vs. 3. Adding conditional compilation within functions is ugly and
> hard to track for both branches.
That abstraction has already happened -- it's in util/crypto.c; there's
simply a chunk of code that gmime 2.6 needs that gmime 3.0 does not. :/
i welcome suggestions for how to rewrite this if you really think it's a
problem, but i hope the latest revision of this series (which groups all
changes into a single, cleaned-up #if block) will be acceptable.
--dkg
More information about the notmuch
mailing list