[PATCH] lib: index the content-type of the parts of encrypted messages

Daniel Kahn Gillmor dkg at fifthhorseman.net
Fri Sep 15 07:24:59 PDT 2017


On Fri 2017-09-15 10:48:08 +0300, Jani Nikula wrote:
> Nitpick, the extra braces aren't needed here. But the patch does what
> it says on the box.

Thanks for the review!

I prefer to keep the braces, i think they make it clearer what's
happening.  If whoever's merging prefers to remove the braces, i'd be
willing to accept that too.

This section is also updated in my cleartext-index series, which depends
on this cleanup series, so removing the braces will require yet another
rebase of that series, which is what i'd really like to get to.

> I was first wondering about the usefulness of indexing
> "application/octet-stream" for the encrypted content parts, but then I
> think it's good for completeness.

It would also make it possible to scan a maildir for encrypted messages
that *don't* have application/octet-stream for example, to see what is
going on there.

      --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20170915/7c451081/attachment.sig>


More information about the notmuch mailing list