[PATCH] lib&cli: use g_object_new instead of g_object_newv
Tomi Ollila
tomi.ollila at iki.fi
Sun Sep 3 13:26:56 PDT 2017
On Sun, Sep 03 2017, David Bremner wrote:
> 'g_object_newv' is deprecated, and prints annoying warnings. The
> warnings suggest using 'g_object_new_with_properties', but that's only
> available since glib 2.55 (i.e. a month ago as of this writing).
> Since we don't actuall pass any properties, it seems we can just call
> 'g_object_new'.
trivial enough to LGTM w/o further ado.
> ---
> gmime-filter-reply.c | 2 +-
> lib/index.cc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gmime-filter-reply.c b/gmime-filter-reply.c
> index b269db4e..847426bf 100644
> --- a/gmime-filter-reply.c
> +++ b/gmime-filter-reply.c
> @@ -201,7 +201,7 @@ g_mime_filter_reply_new (gboolean encode)
> {
> GMimeFilterReply *new_reply;
>
> - new_reply = (GMimeFilterReply *) g_object_newv (GMIME_TYPE_FILTER_REPLY, 0, NULL);
> + new_reply = (GMimeFilterReply *) g_object_new (GMIME_TYPE_FILTER_REPLY, NULL);
> new_reply->encode = encode;
>
> return (GMimeFilter *) new_reply;
> diff --git a/lib/index.cc b/lib/index.cc
> index 10420d84..2b98b588 100644
> --- a/lib/index.cc
> +++ b/lib/index.cc
> @@ -261,7 +261,7 @@ notmuch_filter_discard_non_term_new (GMimeContentType *content_type)
> type = g_type_register_static (GMIME_TYPE_FILTER, "NotmuchFilterDiscardNonTerm", &info, (GTypeFlags) 0);
> }
>
> - filter = (NotmuchFilterDiscardNonTerm *) g_object_newv (type, 0, NULL);
> + filter = (NotmuchFilterDiscardNonTerm *) g_object_new (type, NULL);
> filter->content_type = content_type;
> filter->state = 0;
> if (g_mime_content_type_is_type (content_type, "text", "html")) {
> --
> 2.14.1
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
More information about the notmuch
mailing list