[PATCH] crypto: gracefully handle gmime errors

[Jan Malakhovski]

David Bremner <david at tethera.net> writes:

> Jan Malakhovski <oxij at oxij.org> writes:
>
>>
>> The test suite has such a message already. "signature verification
>> (notmuch CLI)" test fails with a SIGSEGV when built with gmime-2.6.23.
>>
>> T355-smime: Testing S/MIME signature verification and decryption
>> gpgsm: keybox '/tmp/nix-build-notmuch-0.25.drv-0/notmuch-test-8789.qe2sRf/gnupg/pubring.kbx' created
>>  PASS   emacs delivery of S/MIME signed message
>>  PASS   emacs delivery of S/MIME encrypted + signed message
>>  PASS   Signature verification (openssl)
>>  FAIL   signature verification (notmuch CLI)
>
> Actually now that I try, I can't duplicate this failure on Debian (also
> with gmime-2.6.23). Matt, can you confirm or deny that the failures you
> were having were with SMIME signed messages?

Versions of all dependencies as per diff of `nix-store -q --requisites`
between two builds, if it helps:

--- /proc/self/fd/11	2017-08-31 23:53:53.387411873 +0000
+++ /proc/self/fd/12	2017-08-31 23:53:53.405412185 +0000
@@ -1,10 +1,9 @@
 /nix/store/y4ihw837rm0s0ps5f31zi18w7ri1a0y8-glibc-2.25
 /nix/store/bcg4yk2kinfd9703m3qlh7gkivkg1kqj-zlib-1.2.11
 /nix/store/2hd1rag058ija0ivn3ip4lfjdsnk1l9r-glib-2.52.1
-/nix/store/3ia3cz1hikmfhwgmbyf0j005myh9y7rb-gmime-2.6.23
+/nix/store/8ms9r6qw41rds9f59swiaaypmx07p376-gmime-3.0.1
 /nix/store/axldd4qjamb2c1lgi7d6k3s51qyy4610-bash-4.4-p12
 /nix/store/ds1qs36gzkzr4z6fvpdchwkhgkwq94p5-gcc-6.4.0-lib
 /nix/store/9636ksx6g2yifzx4d3wcfir87s3dzlja-xapian-1.4.4
-/nix/store/g3px2vjcfhaq7f6hdm1xnmbk5ry5qjrv-gnupg-2.1.23
 /nix/store/wfq4aip4ljnv0irx0r8b54pihfhz6im9-talloc-2.1.8
-/nix/store/h0lzwh8pmpcdzg7q8xl9bj5lzd9rvf71-notmuch-0.25
+/nix/store/kfwjlk0mqzisc77zxiflbamnrc52mfhq-notmuch-0.25

I wonder why gnupg stops getting referenced with gmime-3.0.1. My guess
is that `./configure` does something very different when compiling with
gmime-3.

Also, I think another message of mine got stuck in premoderation because
it had a biggish attachment with a build log.

Cheers,
  Jan