[PATCH] python: open messages in binary mode

David Bremner david at tethera.net
Thu Aug 24 15:11:48 PDT 2017


Florian Klink <flokli at flokli.de> writes:

> To fix this, read file in binary mode and pass to
> email.message_from_binary_file(fp).
>

Thanks for the patch, but notmuch is not (yet) python3 only. Apparently
that function is only since python 3.2. I'm not sure if/when we'll drop
python 2.7 support, but not without deprecating it for a few releases.

Also, since compatibility is a bit tricky here, it would be great to
have a test. See test/T390-python.sh for some examples.

d


More information about the notmuch mailing list