[PATCH] go: update bindings to compile with notmuch 0.25
David Bremner
david at tethera.net
Sat Aug 12 07:15:40 PDT 2017
Kamil Klimkiewicz <miglanz at gmail.com> writes:
> Attached is a simple patch that fixes go bindings to compile with
> notmuch 0.25. Please note it doesn't change the go API, ie. go methods
> *don't* return Status values. I am not sure you also want to break go
> API with the update. If you do, I can update the patch to return
> go-idiomatic (*Messages, Status) tuple.
for some reason this patch doesn't apply to current master
> ---
> contrib/go/src/notmuch/notmuch.go | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/contrib/go/src/notmuch/notmuch.go
> b/contrib/go/src/notmuch/notmuch.go
> index 2d684311..936f927c 100644
> --- a/contrib/go/src/notmuch/notmuch.go
> +++ b/contrib/go/src/notmuch/notmuch.go
> @@ -455,11 +455,12 @@ func (self *Query) GetSort() Sort {
> * If a Xapian exception occurs this function will return NULL.
> */
> func (self *Query) SearchThreads() *Threads {
> - threads := C.notmuch_query_search_threads(self.query)
> - if threads == nil {
> + var threads Threads
> + C.notmuch_query_search_threads(self.query, &threads.threads)
> + if threads.threads == nil {
it seems like it would be better to check the return value of
notmuch_query_search_threads here, wouldn't it?
> /* Destroy a notmuch_query_t along with any associated resources.
> @@ -531,7 +533,9 @@ func (self *Query) Destroy() {
> * printing a message).
> */
> func (self *Query) CountMessages() uint {
> - return uint(C.notmuch_query_count_messages(self.query))
> + var count C.uint
> + C.notmuch_query_count_messages(self.query, &count)
> + return uint(count)
> }
Here especially you should check the return value since the API does not
promise anything about the value of count in case of errors.
d
More information about the notmuch
mailing list