[PATCH 1/2] Ensure that "notmuch reply" succeeds during testing.

Daniel Kahn Gillmor dkg at fifthhorseman.net
Fri Jul 14 10:08:50 PDT 2017


On Fri 2017-07-14 11:42:43 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:
>> -output=$(notmuch reply id:${gen_msg_id})
>> +output=$(notmuch reply id:${gen_msg_id} || echo failed)
>
> I wonder if we're going to touch this code if we should DTRT™ and switch
> to redirecting stdin and stderr to a file. Then when we have failures we
> will at least have a little bit more information, especially in user bug
> reports.

redirecting stdin as well?  i'm not sure what you'd do with stdin.
makes sense for for stderr, though i don't know the test suite well
enough to instrument it The Right Way™.  I'm happy to be pointed to an
example, though.

I like this idea generally, but i hope it won't block a specific
improvement, which i think this is.

        --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20170714/ee6fdba6/attachment.sig>


More information about the notmuch mailing list