[PATCH 0/4] build fixes and improvements

Jani Nikula jani at nikula.org
Sun Apr 23 13:01:54 PDT 2017


I was looking into the Meson build system [1], and tried converting
notmuch to use it as a learning experience. I'm not sure if that'll lead
anywhere, but I noted some issues in the current build while at it.

The first two are genuine fixes, the last two I think make the build
easier to understand, but also make it more straightforward to convert
the build to Meson.

BR,
Jani.


Jani Nikula (4):
  build: do not export compat functions from lib
  compat: don't include compat.h from the feature test source
  build: switch to hiding libnotmuch symbols by default
  build: visibility=default for library structs is no longer needed

 .gitignore                 |  1 -
 Makefile.local             |  1 +
 compat/have_timegm.c       |  1 -
 lib/Makefile.local         | 25 ++++++++++++-------------
 lib/database-private.h     |  4 ----
 lib/gen-version-script.sh  | 29 -----------------------------
 lib/message.cc             |  2 +-
 lib/notmuch-private.h      | 14 ++------------
 lib/notmuch.h              |  4 ++++
 lib/notmuch.sym            |  7 +++++++
 lib/query.cc               |  2 +-
 lib/thread.cc              |  2 +-
 test/T360-symbol-hiding.sh |  2 +-
 13 files changed, 30 insertions(+), 64 deletions(-)
 delete mode 100644 lib/gen-version-script.sh
 create mode 100644 lib/notmuch.sym

-- 
2.11.0



More information about the notmuch mailing list