[PATCH] test: verify test database v1 checksum in more portable way
tomi.ollila at iki.fi
Mon Mar 13 12:32:02 PDT 2017
On Mon, Mar 13 2017, David Bremner <david at tethera.net> wrote:
> Tomi Ollila <tomi.ollila at iki.fi> writes:
>> Replaced use of sha256 (gnu coreutils binary) with more portable
>> openssl sha256 execution.
>> Works on Linux and also on my FreeBSD KVM environment.
> There's a tradeoff here. In a minimal GNU/Linux environment coreutils is
> there but not openssl. So I don't mind the substitution (for the test
Köh... That did not come into my mind, but perhaps that is the fun of it.
I'd rather let this test fail on non-coreutils system (for the time being)
than introduce more dependencies ;) -- have to think whether proposing
And had to test that one:
localhost$ sudo docker run --rm -it debian:8.7 /bin/bash
root at 1c96aac39246:/# openssl
bash: openssl: command not found
root at 1c96aac39246:/# sha1sum < /dev/null
root at 1c96aac39246:/# exit
Marking this particular patch obsolete.
> suite), but I think you need to add a
> "test_require_external prereq openssl" or equivalent to T530-upgrade.sh
> This will also require adding openssl as a debian build dependency; I
> can also live with that, although it might inconvenience some people
> building the debian-snapshot target.
> There's something aesthetically displeasing about hardcoding the
> checksum into the test script but I think I'm just grumbling at this
I personally disagree (in specific cases like this), but would not have
done that if there were simpler solution using the file...
More information about the notmuch