[PATCH] lib/database: reduce try block scope to things that really need it

David Bremner david at tethera.net
Fri Mar 10 05:20:41 PST 2017

Jani Nikula <jani at nikula.org> writes:

> No need to maintain the pure C stuff within a try block, it's arguably
> confusing. This also reduces indent for a bunch of code. No functional
> changes.

I didn't trace all the code paths, but there is the possibility this
will allow some uncaught exceptions deeper in the "pure C stuff" to
escape (along the lines of what we saw with
_notmuch_message_ensure_metadata. As long as we agree that those are
bugs that should be fixed, the beginning of a release cycle seems like a
reasonable time to deal with that.


More information about the notmuch mailing list