[patch v5 5/6] lib: add mid: as a synonym for id:

Jani Nikula jani at nikula.org
Sun Feb 26 11:52:28 PST 2017


On Thu, 16 Feb 2017, David Bremner <david at tethera.net> wrote:
> mid: is the url scheme suggested by URL 2392. We also plan to
> introduce more flexible searches for mid: than are possible with
> id: (in order not to break assumptions about the special behaviour of
> id:, e.g. identifying at most one message).

LGTM.

> ---
>  lib/database.cc     | 1 +
>  test/T080-search.sh | 6 ++++++
>  2 files changed, 7 insertions(+)
>
> diff --git a/lib/database.cc b/lib/database.cc
> index ee971f32..21c8c5f2 100644
> --- a/lib/database.cc
> +++ b/lib/database.cc
> @@ -262,6 +262,7 @@ prefix_t prefix_table[] = {
>      { "tag",			"K",		NOTMUCH_FIELD_EXTERNAL },
>      { "is",			"K",		NOTMUCH_FIELD_EXTERNAL },
>      { "id",			"Q",		NOTMUCH_FIELD_EXTERNAL },
> +    { "mid",			"Q",		NOTMUCH_FIELD_EXTERNAL },
>      { "path",			"P",		NOTMUCH_FIELD_EXTERNAL },
>      { "property",		"XPROPERTY",	NOTMUCH_FIELD_EXTERNAL },
>      /*
> diff --git a/test/T080-search.sh b/test/T080-search.sh
> index 5e8b20ce..6149da93 100755
> --- a/test/T080-search.sh
> +++ b/test/T080-search.sh
> @@ -34,6 +34,11 @@ add_message '[subject]="search by id"' '[date]="Sat, 01 Jan 2000 12:00:00 -0000"
>  output=$(notmuch search id:${gen_msg_id} | notmuch_search_sanitize)
>  test_expect_equal "$output" "thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; search by id (inbox unread)"
>  
> +test_begin_subtest "Search by mid:"
> +add_message '[subject]="search by mid"' '[date]="Sat, 01 Jan 2000 12:00:00 -0000"'
> +output=$(notmuch search mid:${gen_msg_id} | notmuch_search_sanitize)
> +test_expect_equal "$output" "thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; search by mid (inbox unread)"
> +
>  test_begin_subtest "Search by tag:"
>  add_message '[subject]="search by tag"' '[date]="Sat, 01 Jan 2000 12:00:00 -0000"'
>  notmuch tag +searchbytag id:${gen_msg_id}
> @@ -127,6 +132,7 @@ thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; search by to (inbox unread)
>  thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; subjectsearchtest (inbox unread)
>  thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; utf8-sübjéct (inbox unread)
>  thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; search by id (inbox unread)
> +thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; search by mid (inbox unread)
>  thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; search by tag (inbox searchbytag unread)
>  thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; search by thread (inbox unread)
>  thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; body search (phrase) (inbox unread)
> -- 
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch


More information about the notmuch mailing list