[PATCH v2] emacs: add compatability functions for emacs 23

[David Bremner]

Mark Walters <markwalters1009 at gmail.com> writes:

> Some of the recent changes to the emacs code have used functions
> introduced in emacs 24. The functions used are read-char-choice and
> setq-local. This changeset adds compatability functions to
> notmuch-lib so that it should work on emacs 23.
> ---

> 1) please could someone with emacs 23 see if the testsuite passes? My
> system with emacs 23 is so outdated the test suite doesn't run (wrong
> python versions I think).

I get many failures like

emacsclient.emacs23: connect: Connection refused
emacsclient.emacs23: error accessing socket "/tmp/emacs1000/notmuch-test-suite-21492"

At a guess, somehow the server is shutting down/dying. I did manage to
manually run an emacs server on this machine, and the socket is being
created in the file system.

> 2) Is the copyright notice I have included above the two functions
> sufficient, and suitably placed?

I think it would be best to modify the copyright at the top of the
file. So to avoid confusing (if for some unforseen reason we wanted to
relicense this file), it might be best to go with a seperate file. But
lets see if someone can figure out the issue with the test suite before
putting much more effort into it.