[PATCH 1/2] emacs: tag-jump: make k binding for the reverse tag change map

Tomi Ollila tomi.ollila at iki.fi
Thu Oct 6 11:23:50 PDT 2016


On Thu, Oct 06 2016, Mark Walters <markwalters1009 at gmail.com> wrote:

> Currently, by default k invokes the tag-jump menu, and following it by
> r invokes the reverse tag change jump menu. This is awkward to type
> (e.g. k r u for undoing a -unread change). This changes it so that k
> followed by k invokes the reverse menu.
> ---
>
> There has been discussion on irc and reasonable agreement that this is
> more convenient.
>
> This patch can be applied on its own, or with the second patch. Since
> it is relatively hard to configure the internal binding to jump to the
> reverse tag changes it might be worth applying. Alternatively we could
> have a defvar variable that specifies the key, so a user can configure
> it if they want.
>
> Since the first patch changes default keybindigs it is probably worth
> applying that one soon, and then considering what, if anything, to do
> about the second.

Agreed -- and putting the "k" into a variable can also be applied
separately.



>
> Best wishes
>
> Mark
>
>
>
>
>
> emacs/notmuch-tag.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index 49662c2..36a498d 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -523,7 +523,7 @@ and vice versa."
>  	(push (list key name-string
>  		     `(lambda () (,tag-function ',tag-change)))
>  	      action-map)))
> -    (push (list "r" (if reverse
> +    (push (list "k" (if reverse
>  			"Forward tag changes "
>  		      "Reverse tag changes")
>  		(apply-partially 'notmuch-tag-jump (not reverse)))
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch at notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch


More information about the notmuch mailing list