[PATCH] lib: add talloc reference from string map iterator to map

[David Bremner]

Tomi Ollila <tomi.ollila at iki.fi> writes:
>
> I tried to run this under valgrind ( ./T610-message-property.sh --valgrind )
> but got so noisy output that I could not resolve anything definite
> from it.

Hmm. On a related topic, --valgrind seems broken here:

╭─ zancas:software/upstream/notmuch/test 
╰─ (git)-[master]-% ./T610-message-property.sh --val
./test-lib.sh:[:18: unknown condition: -lt
./test-lib.sh:27: command not found: shopt

test-lib: Testing message property API
cc1: error: unrecognised debug output level ' -O0'

All the tests fail because none of the binaries get built.

Same results if I run from bash instead of my normal zsh.

> Also /T600-named-queries.sh --val printed noisy output -- but perhaps
> the noise difference (less there) can inform something.

I ran 
% ./T610-message-property --debug
% cd tmp.T610-message-property
% LD_LIBRARY_PATH=../../lib valgrind ./test6 `pwd`/mail

>
> Anyway, this seems to fix a bug that might affect someone, and at least
> the situation is better with this so this should be pushed soon...
>
> Btw: does 'Debian stable' refer to Debian 8.6(+) -- just for the record
> anyone reading this message years from now :D

Yes, thanks for reminding me to upgrade ;).  I tested and the failure is
there with 8.6

d