[PATCH v2] emacs: reply: remove wrong sig/enc status buttons

Mark Walters markwalters1009 at gmail.com
Tue Sep 13 00:35:29 PDT 2016


On Tue, 13 Sep 2016, Daniel Kahn Gillmor <dkg at fifthhorseman.net> wrote:
> [ Unknown signature status ]
> Hi Mark--
>
> On Tue 2016-09-13 00:12:19 +0200, Mark Walters wrote:
>> This stopps the (usually incorrect) sigstatus and encstatus buttons
>> appearing when replying in emacs, and updates the test suite to match.
>>
>> Overriding the status button functions is a little unusual but much
>> less intrusive than passing an argument all the way down the call
>> chain. It also makes it clear exactly what it does.
>>
>> We also hide the application/pgp-encrypted part as it can only contain
>> "Version: 1". We do this in notmuch show, which means it also happens
>> when replying.
>>
>> ---
>>
>> This fixes the bug David mentioned of Version: 1 appearing in the
>> reply. We actually fix it by making notmuch-show.el not display this
>> either.
>
> hm, fwiw, i am still seeing Version: 1 in both the replies and in the
> plaintext message body, even with this patch applied :/
>
> not sure what i should do to give you more debugging info.  any
> pointers?

Hi

Can you post a screenshot of the message in notmuch-show, and the output
of printmimestructure for such a message

if it is hard to reproduce with a message you can make public, then the
main thing I care about is whether the "Version: 1" is in a part with
mime type application/pgp-encrypted.

Best wishes

Mark


More information about the notmuch mailing list