[PATCH] lib: reword comment about XFOLDER: prefix
David Bremner
david at tethera.net
Thu Aug 18 01:14:56 PDT 2016
I believe the current one is misleading, because in my experiments
Xapian did not add : when prefix and term were both upper case. Indeed,
it's hard to see how it could, because prefixes are added at a layer
above Xapian in our code. See _notmuch_message_add_term for an example.
Also try to explain why this is a good idea.
---
lib/database.cc | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/database.cc b/lib/database.cc
index 57a98c9..30ee303 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -260,10 +260,10 @@ static prefix_t BOOLEAN_PREFIX_EXTERNAL[] = {
{ "id", "Q" },
{ "path", "P" },
/*
- * Without the ":", since this is a multi-letter prefix, Xapian
- * will add a colon itself if the first letter of the path is
- * upper-case ASCII. Including the ":" forces there to always be a
- * colon, which keeps our own logic simpler.
+ * Unconditionally add ':' to reduce potential ambiguity with
+ * overlapping prefixes and/or terms that start with capital
+ * letters. See xapian document termprefixes.html for related
+ * discussion.
*/
{ "folder", "XFOLDER:" },
};
--
2.8.1
More information about the notmuch
mailing list