[PATCH v2 3/7] fix thread breakage via ghost-on-removal

[David Bremner]

Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:

>>
>> Outside of this patch, but in some of the next messages, adds functions
>> _notmuch_message_has_term() and _notmuch_message_has_term_st(). Perhaps
>> the _notmuch_message_has_term() could be left unimplemented?
>
> yeah, i can do that, though i have to say it's programmatically
> convenient to have a simple boolean test that defaults to some value if
> there was an error.

Maybe this is obvious, but we rely heavily in the notmuch code base on
NOTMUCH_STATUS_SUCCESS==0, so the following idiom is pretty common,

      status = notmuch_status_returning_thing (... &out);
      if (status) {
         /* error path */
      }

      /* otherwise, deal with out */