[PATCH] use notmuch_database_open_verbose

David Bremner david at tethera.net
Sat Mar 12 08:33:50 PST 2016


David Bremner <david at tethera.net> writes:

>> -    """notmuch_database_open"""
>> -    _open = nmlib.notmuch_database_open
>> +    """notmuch_database_open_verbose"""
>> +    _open = nmlib.notmuch_database_open_verbose
>>      _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)]
>>      _open.restype = c_uint
>
> I expect you probably want to add the new binding, rather than replacing
> the old one. Otherwise updating the bindings will break all bindings
> using scripts.

Oh silly me. That's not actually exposed to the python API, so that's
fine. On the other hand, don't you want to update the argument types and
do something useful (throw an exception?) with the returned message?  As
it stands you lose information.

d


More information about the notmuch mailing list